Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEureka discovery #1506
Comments
This comment has been minimized.
This comment has been minimized.
|
If that is a widely-enough used SD mechanism, then I can imagine it could get added to Prometheus itself. However, SD mechanisms are usually added (via PRs) and maintained by people who actually use a specific type of service discovery, since they are in the best position to test it and know the practical design and implementation considerations. So I guess, feel free to send a PR - and it would help if there was some interest in maintaining it, as well :) |
beorn7
added
the
feature-request
label
Mar 29, 2016
fabxc
added
kind/enhancement
and removed
feature request
labels
Apr 28, 2016
This comment has been minimized.
This comment has been minimized.
pparth
commented
Jul 5, 2016
|
+1 |
12 similar comments
This comment has been minimized.
This comment has been minimized.
fabMrc
commented
Oct 5, 2016
|
+1 |
This comment has been minimized.
This comment has been minimized.
manuelpolacek
commented
Dec 8, 2016
|
+1 |
This comment has been minimized.
This comment has been minimized.
hakamairi
commented
Dec 8, 2016
|
+1 |
This comment has been minimized.
This comment has been minimized.
ankurbhakta
commented
Feb 11, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
jtlisi
commented
Feb 15, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
ipalbeniz
commented
Feb 21, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
fedy2
commented
Mar 18, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
olafgeibig
commented
Mar 23, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
chenapan
commented
Apr 9, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
itshanney
commented
May 11, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
joaovicente
commented
May 22, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
ankurbhakta
commented
May 28, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
Friendly reminder that commenting +1 is mostly noise for maintainers and alone does not incentivise us to work on any particular feature. As an open source project, we welcome productive discussion and contributions. |
brian-brazil
added
the
component/service discovery
label
Jul 7, 2017
brian-brazil
added
the
priority/Pmaybe
label
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
yarix
commented
Nov 8, 2017
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
Locking this issue now. |
prometheus
locked and limited conversation to collaborators
Nov 8, 2017
prometheus
unlocked this conversation
Mar 21, 2018
This comment has been minimized.
This comment has been minimized.
tine2k
commented
Mar 21, 2018
|
I have written an adapter that you can deploy with your Eureka instance. This adapter provides several HTTP endpoints that return information of the registered services and are compatible with the Prometheus' Consul discovery client (consul_sd_config). It is available as a Spring Boot starter on Github: https://github.com/twinformatics/eureka-consul-adapter |
This comment has been minimized.
This comment has been minimized.
davidkarlsen
commented
Mar 21, 2018
|
Very interesting - I looked at it yesterday - and it is just what I need (as I want to avoid the consul full-mesh stuff for agents). Does eureka have a label concept like consul? And are these mapped over? |
This comment has been minimized.
This comment has been minimized.
tine2k
commented
Mar 21, 2018
|
No, eureka does not support labels. However, there is something called node metdata that clients can send along with their registration. By overriding InstanceInfoMapper of the adapter you return this metadata as service tags, which you can use as labels in Prometheus. |
This comment has been minimized.
This comment has been minimized.
|
Closing the issue as unfortunately, we are currently not accepting new integrations. See #1506 (comment) for an alternative. We can only provide the stability and performance we want to provide if we can properly maintain the codebase. This includes, amongst others, test integrations in an automated and scalable fashion. For this reason, we are suggesting people integrate with the help of our generic interfaces. We have an integrations page on which integrations using our generic interfaces are listed. Even if existing integrations can not be tested in an automated fashion, we will not remove them for reasons of compatibility. This also means that any additions we take on, or any changes to existing integrations we make or accept, will mean maintaining and testing these until at least the next major version, realistically even beyond that. Feel free to question this answer on our developer mailing list, but be aware it's unlikely that you will get a different answer. |
simonpasquier
closed this
Aug 1, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
drax68 commentedMar 28, 2016
Hi. Could you please add Eureka to discovery backends?
It has quite straightforward api and existing client in go