Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eureka discovery #1506

Closed
drax68 opened this Issue Mar 28, 2016 · 22 comments

Comments

Projects
None yet
@drax68
Copy link

drax68 commented Mar 28, 2016

Hi. Could you please add Eureka to discovery backends?
It has quite straightforward api and existing client in go

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Mar 28, 2016

If that is a widely-enough used SD mechanism, then I can imagine it could get added to Prometheus itself. However, SD mechanisms are usually added (via PRs) and maintained by people who actually use a specific type of service discovery, since they are in the best position to test it and know the practical design and implementation considerations. So I guess, feel free to send a PR - and it would help if there was some interest in maintaining it, as well :)

@pparth

This comment has been minimized.

Copy link

pparth commented Jul 5, 2016

+1

12 similar comments
@fabMrc

This comment has been minimized.

Copy link

fabMrc commented Oct 5, 2016

+1

@manuelpolacek

This comment has been minimized.

Copy link

manuelpolacek commented Dec 8, 2016

+1

@hakamairi

This comment has been minimized.

Copy link

hakamairi commented Dec 8, 2016

+1

@ankurbhakta

This comment has been minimized.

Copy link

ankurbhakta commented Feb 11, 2017

+1

@jtlisi

This comment has been minimized.

Copy link

jtlisi commented Feb 15, 2017

+1

@ipalbeniz

This comment has been minimized.

Copy link

ipalbeniz commented Feb 21, 2017

+1

@fedy2

This comment has been minimized.

Copy link

fedy2 commented Mar 18, 2017

+1

@olafgeibig

This comment has been minimized.

Copy link

olafgeibig commented Mar 23, 2017

+1

@chenapan

This comment has been minimized.

Copy link

chenapan commented Apr 9, 2017

+1

@itshanney

This comment has been minimized.

Copy link

itshanney commented May 11, 2017

+1

@joaovicente

This comment has been minimized.

Copy link

joaovicente commented May 22, 2017

+1

@ankurbhakta

This comment has been minimized.

Copy link

ankurbhakta commented May 28, 2017

+1

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 29, 2017

Friendly reminder that commenting +1 is mostly noise for maintainers and alone does not incentivise us to work on any particular feature. As an open source project, we welcome productive discussion and contributions.
If you just want to express that you agree with the feature request, GitHub has reaction emojis, which do not flood our inboxes.

@yarix

This comment has been minimized.

Copy link

yarix commented Nov 8, 2017

+1

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Nov 8, 2017

Locking this issue now.

@prometheus prometheus locked and limited conversation to collaborators Nov 8, 2017

@prometheus prometheus unlocked this conversation Mar 21, 2018

@tine2k

This comment has been minimized.

Copy link

tine2k commented Mar 21, 2018

I have written an adapter that you can deploy with your Eureka instance. This adapter provides several HTTP endpoints that return information of the registered services and are compatible with the Prometheus' Consul discovery client (consul_sd_config). It is available as a Spring Boot starter on Github: https://github.com/twinformatics/eureka-consul-adapter

@davidkarlsen

This comment has been minimized.

Copy link

davidkarlsen commented Mar 21, 2018

Very interesting - I looked at it yesterday - and it is just what I need (as I want to avoid the consul full-mesh stuff for agents). Does eureka have a label concept like consul? And are these mapped over?

@tine2k

This comment has been minimized.

Copy link

tine2k commented Mar 21, 2018

No, eureka does not support labels. However, there is something called node metdata that clients can send along with their registration. By overriding InstanceInfoMapper of the adapter you return this metadata as service tags, which you can use as labels in Prometheus.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Aug 1, 2018

Closing the issue as unfortunately, we are currently not accepting new integrations. See #1506 (comment) for an alternative.

We can only provide the stability and performance we want to provide if we can properly maintain the codebase. This includes, amongst others, test integrations in an automated and scalable fashion. For this reason, we are suggesting people integrate with the help of our generic interfaces. We have an integrations page on which integrations using our generic interfaces are listed.

Even if existing integrations can not be tested in an automated fashion, we will not remove them for reasons of compatibility. This also means that any additions we take on, or any changes to existing integrations we make or accept, will mean maintaining and testing these until at least the next major version, realistically even beyond that.

Feel free to question this answer on our developer mailing list, but be aware it's unlikely that you will get a different answer.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.