Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider disabling fsnotify in certain architectures #1507

Closed
TheTincho opened this Issue Mar 29, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@TheTincho
Copy link
Contributor

TheTincho commented Mar 29, 2016

Hi,

As noted in bug fsnotify/fsnotify#130, fsnotify fails to work correctly (or at all) in arm64, ppc64 and ppc64el.

This was preventing prometheus to be accepted in Debian testing, so while this is solved upstream, I hacked together a patch to disable fsnotify and rely only on refresh intervals in those architectures. You might want to consider applying something similar, so prom keeps working.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Mar 29, 2016

That seems sane 👍

On Tue, Mar 29, 2016, 3:14 AM Martín Ferrari notifications@github.com
wrote:

Hi,

As noted in bug fsnotify/fsnotify#130
fsnotify/fsnotify#130, fsnotify fails to work
correctly (or at all) in arm64, ppc64 and ppc64el.

This was preventing prometheus to be accepted in Debian testing, so while
this is solved upstream, I hacked together a patch to disable fsnotify
and rely only on refresh intervals in those architectures. You might want
to consider applying something similar, so prom keeps working.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1507

@beorn7 beorn7 added the bug label Mar 29, 2016

@TheTincho

This comment has been minimized.

Copy link
Contributor Author

TheTincho commented Mar 29, 2016

As a data point, the new Debian release with this patch applies compiles and passes tests in all arches: https://buildd.debian.org/status/package.php?p=prometheus

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Apr 8, 2016

Do you want to send on a PR with that patch?

@TheTincho

This comment has been minimized.

Copy link
Contributor Author

TheTincho commented Apr 9, 2016

Sure, will do.

I see the fsnotify people are moving to fix this issue, but it might take a while, as it might involve getting fixes into golang itself.

@TheTincho

This comment has been minimized.

Copy link
Contributor Author

TheTincho commented Apr 9, 2016

Done.

@fabxc fabxc added this to the v1.0.0 milestone Apr 25, 2016

@fabxc fabxc added kind/bug and removed bug labels Apr 28, 2016

fabxc added a commit that referenced this issue Jun 8, 2016

vendor: update gopkg.in/fsnotify.v1
This updates the fsnotify package, which now uses golang.org/x/sys/unix
package. This fixes #1507.

@fabxc fabxc closed this in #1715 Jun 8, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.