Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPlease consider disabling fsnotify in certain architectures #1507
Comments
This comment has been minimized.
This comment has been minimized.
|
That seems sane On Tue, Mar 29, 2016, 3:14 AM Martín Ferrari notifications@github.com
|
beorn7
added
the
bug
label
Mar 29, 2016
This comment has been minimized.
This comment has been minimized.
|
As a data point, the new Debian release with this patch applies compiles and passes tests in all arches: https://buildd.debian.org/status/package.php?p=prometheus |
This comment has been minimized.
This comment has been minimized.
|
Do you want to send on a PR with that patch? |
This comment has been minimized.
This comment has been minimized.
|
Sure, will do. I see the fsnotify people are moving to fix this issue, but it might take a while, as it might involve getting fixes into golang itself. |
TheTincho
referenced this issue
Apr 9, 2016
Closed
Disable fsnofity in arm64, ppc64, and ppc64el. #1541
This comment has been minimized.
This comment has been minimized.
|
Done. |
fabxc
added this to the v1.0.0 milestone
Apr 25, 2016
fabxc
added
kind/bug
and removed
bug
labels
Apr 28, 2016
fabxc
added a commit
that referenced
this issue
Jun 8, 2016
fabxc
closed this
in
#1715
Jun 8, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
TheTincho commentedMar 29, 2016
Hi,
As noted in bug fsnotify/fsnotify#130, fsnotify fails to work correctly (or at all) in arm64, ppc64 and ppc64el.
This was preventing prometheus to be accepted in Debian testing, so while this is solved upstream, I hacked together a patch to disable fsnotify and rely only on refresh intervals in those architectures. You might want to consider applying something similar, so prom keeps working.