Rules became invalid in 0.18.0rc1

[hryamzik]

This rule:

ALERT low_disk_space
  IF round(node_filesystem_free * 100 / node_filesystem_size) < 15
  SUMMARY "Less than {{$value}}% left on disk {{$labels.mountpoint}}, host {{$labels.instance}}"

results in

FAILED: parse error at line 6, char 12: unexpected string "\"Less than"... in record statement, expected "="

The same about this rule:

ALERT node_down
  IF up == 0
  FOR 5m
  WITH {
    severity="page"
  }
  SUMMARY "Instance {{$labels.instance}} down"
  DESCRIPTION "{{$labels.instance}} of job {{$labels.job}} has been down for more than 5 minutes."

FAILED: parse error at line 15, char 4: unexpected identifier "SUMMARY" in record statement, expected "="

Replacing DESCRIPTION and SUMMARY to a single ANNOTATIONS line doesn't help. What am I doing wrong?

[hryamzik]

OK, it turns out the correct syntax now is as follows:

ALERT node_down
  IF up == 0
  FOR 5m
  LABELS {
    severity="page"
  }
  ANNOTATIONS {
      summary = "Instance {{$labels.instance}} down",
      description = "{{$labels.instance}} of job {{$labels.job}} has been down for more than 5 minutes."
  }

[fabxc]

Yes, we kept both variants working for 0.17.0 and finally dropped support
for the old one in 0.18.0.
@discordianfish has a script that converts the syntax automatically.

On Sat, Apr 9, 2016 at 12:39 PM Roman Belyakovsky notifications@github.com
wrote:

Closed #1539 #1539.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1539 (comment)

[juliusv]

@fabxc Shouldn't that be explicitly listed in the 0.18.0rc1 changelog entry again?

[fabxc]

Yes, it should – forgot about that. Changing.

[juliusv]

👍

[discordianfish]

@xbglowx Wrote this script to do the translation: https://gist.github.com/xbglowx/d798da98ff9937e33862b285d0121bde

[xbglowx]

The gist above is for the setup where every alerting rule is in its own separate file. Only tested on my environment.

[JakimLi]

change to ANNOTATIONS doesn't help, keep giving errors like:

"Error loading rules, previous rule set restored: error parsing /workshop_alerting.rules: parse error at line 10, char 4: unexpected <ANNOTATIONS> in record statement, expected \"=\"" source="manager.go:419"

And my rules are like:

ALERT ReviewServiceNoInstances
  IF absent(max_over_time(consul_health_service_status{service="review-service-admin"}[30s])) == 1
  FOR 30s
  WITH {
    severity="page"
  }
  ANNOTATIONS {
    summary = "Review service has no registered instances",
    description = "All instances of review service have been down for more than 30 seconds.",
  }

Am I missing anything?

[brian-brazil]

WITH is now LABELS

[JakimLi]

@brian-brazil, thanks so much, you just saved my evening (I am so stupid).

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.