Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate tool to make it easy to share debug information #1551
Comments
grobie
added
the
feature-request
label
Apr 12, 2016
This comment has been minimized.
This comment has been minimized.
|
I was always thinking of a web tool that we could offer where people could enter their Prometheus URL and it would pull interesting info out of it automatically via AJAX and store it as a permalink somehow. However, that would only work for API endpoints, because those have CORS enabled. Of course, we could add more info to those as well. |
This comment has been minimized.
This comment has been minimized.
|
That might be even easier. I think all information of the prometheus server should be exposed via the API. |
fabxc
added
kind/enhancement
and removed
feature request
labels
Apr 28, 2016
grobie
changed the title
Add debug tools to promtool
Create tool to make it easy to share debug information
Aug 18, 2016
brian-brazil
added
priority/P3
component/promtool
labels
Jul 14, 2017
gouthamve
added
low hanging fruit
help wanted
labels
Jan 18, 2018
This comment has been minimized.
This comment has been minimized.
|
Hello, I'm new here! I would like to know if anyone is working on this issue. Any update? |
This comment has been minimized.
This comment has been minimized.
|
@chyeh Hi and welcome! I don't think anyone is currently working on this, but it would still be something that's nice to have. |
This comment has been minimized.
This comment has been minimized.
|
@juliusv tks for your reply. After reading through this thread, I feel this issue needs some further discussion. My question is what exactly is debug information that should be exposed? Before implementation, I might need to confirm the spec of the API with you. |
This comment has been minimized.
This comment has been minimized.
|
Here's an initial list of details that would be useful for debugging:
So, much of the info can be pulled from the APIs that have CORS, but we might also need to scrape /metrics on the Prometheus itself and fetch info from the /debug/pprof endpoints. Both will likely never be available over the main API. Even if a browser could contact /debug/pprof endpoints, it would be hard to interpret the data without running Given that, I think that a command-line tool is the best fit, since it does not have the limitations that a browser has in terms of CORS or being able to connect to a Prometheus server on another network, and it can run other tools like Making it part of |
This comment has been minimized.
This comment has been minimized.
|
@juliusv sorry for the late reply! After a month I'm finally available to switching back to this issue. I've pushed some commits in my own branch and I want to make sure if that's what we need in this issue. In summary, I added two commands:
Does it look like what we need here? Let me know if there is any idea. Tks! |
This comment has been minimized.
This comment has been minimized.
|
@chyeh Hey, that looks pretty good already, without reviewing everything in detail yet! While I like the multi-command approach from a cleanliness persepctive, I wonder if it should just be one big command though that pulls all the debug information together. The main goal is for users to run only one easy step that gives us all the necessary info so that we can help them, so the simpler the better. So it would also be good if it created one large archive with everything in the end. What do you think? Maybe if someone people are worried about including certain information (like /metrics), there could still be a command-line flag that disables some of the debug collectors later. |
This comment has been minimized.
This comment has been minimized.
|
How about the following design:
And I just realized that the Also I'll think about how to add the tests and probably do some refactory before submitting a PR. |
This comment has been minimized.
This comment has been minimized.
|
@chyeh Great!
Maybe |
chyeh
referenced this issue
Jun 9, 2018
Merged
Add 3 commands in `promtool` for getting debug information from prometheus server #4247
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
implemented in #4247 |
krasi-georgiev
closed this
Jul 18, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
grobie commentedApr 12, 2016
A common request during debugging issues is to request various pprof information from users, for example in #1549.
In order to make that process easier for users and less time intensive for developers, it'd be great to have a
promtool debug share-profileto automate the process of: