Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd command line parameters to the configuration file #1599
Comments
This comment has been minimized.
This comment has been minimized.
|
There's significant effort to making a command line option a reloadable config option, and it also ties us down quite a bit in terms of backwards compatibility in addition to making the config more complex. The AM will likely ultimately end up in the config file, but I wouldn't expect many other flags to migrate there. |
brian-brazil
added
the
feature-request
label
Apr 26, 2016
This comment has been minimized.
This comment has been minimized.
|
As mentioned a few times, retention policy would be very helpful. One of the most commonly adjusted values in order to react to a change in number of time series. Changing that value currently means a downtime of 5-10m to restart the server. |
This comment has been minimized.
This comment has been minimized.
|
Retention time is one of the ones I expect to stay as a flag forever, as that's touching quite a few internals and I can imagine the subsystem substantially changing in the future. |
This comment has been minimized.
This comment has been minimized.
|
It'll be inevitable with per series/rule group retention times. |
fabxc
added
kind/enhancement
and removed
feature request
labels
Apr 28, 2016
This comment has been minimized.
This comment has been minimized.
|
I don't think we'll ever be moving all flags to the config file, so closing this off. A few things will be moved to the config file over time. |
brian-brazil
closed this
Oct 26, 2016
This comment has been minimized.
This comment has been minimized.
Perlovka
commented
Dec 21, 2017
|
Is it possible to implement this without re-apply upon reloading? |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
jgillis01 commentedApr 26, 2016
It would be nice to have the prometheus command line parameters added as options in configuration file so that these options could go into effect when the service is reloaded. For example if the alert manager comes online at a later time (or changes endpoint location), an outside process could rewrite the configuration file and HUP the service so that alerts could be pushed to the new endpoint.