Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line parameters to the configuration file #1599

Closed
jgillis01 opened this Issue Apr 26, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@jgillis01
Copy link

jgillis01 commented Apr 26, 2016

It would be nice to have the prometheus command line parameters added as options in configuration file so that these options could go into effect when the service is reloaded. For example if the alert manager comes online at a later time (or changes endpoint location), an outside process could rewrite the configuration file and HUP the service so that alerts could be pushed to the new endpoint.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Apr 26, 2016

There's significant effort to making a command line option a reloadable config option, and it also ties us down quite a bit in terms of backwards compatibility in addition to making the config more complex.

The AM will likely ultimately end up in the config file, but I wouldn't expect many other flags to migrate there.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Apr 26, 2016

As mentioned a few times, retention policy would be very helpful. One of the most commonly adjusted values in order to react to a change in number of time series. Changing that value currently means a downtime of 5-10m to restart the server.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Apr 26, 2016

Retention time is one of the ones I expect to stay as a flag forever, as that's touching quite a few internals and I can imagine the subsystem substantially changing in the future.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Apr 27, 2016

It'll be inevitable with per series/rule group retention times.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Oct 26, 2016

I don't think we'll ever be moving all flags to the config file, so closing this off. A few things will be moved to the config file over time.

@Perlovka

This comment has been minimized.

Copy link

Perlovka commented Dec 21, 2017

Is it possible to implement this without re-apply upon reloading?
Because configuring application options with init system isn't so handy.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.