Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtool: Add querying functionality #1605

Closed
beorn7 opened this Issue Apr 29, 2016 · 13 comments

Comments

Projects
None yet
9 participants
@beorn7
Copy link
Member

beorn7 commented Apr 29, 2016

We want to replace prometheus_cli with promtool.

See also prometheus-junkyard/prometheus_cli#9

@alileza

This comment has been minimized.

Copy link
Contributor

alileza commented Jun 1, 2016

Does anyone working on this?

@beorn7

This comment has been minimized.

Copy link
Member Author

beorn7 commented Jun 1, 2016

I don't think so. @fabxc might know more about the current state about the API client library. See prometheus-junkyard/prometheus_cli#9

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jun 1, 2016

No one is currently working on this.
I'm happy to provide guidance to anyone willing to tackle this.

On Wed, Jun 1, 2016 at 4:21 PM Björn Rabenstein notifications@github.com
wrote:

I don't think so. @fabxc https://github.com/fabxc might know more about
the current state about the API client library. See
prometheus-junkyard/prometheus_cli#9
prometheus-junkyard/prometheus_cli#9


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#1605 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEuA8hxrEyej7tcc7mtL2dzqVPLJCOfwks5qHZVfgaJpZM4IStvv
.

@alileza

This comment has been minimized.

Copy link
Contributor

alileza commented Jun 1, 2016

Nice, i guess i'll try to start working on this.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jun 1, 2016

Sounds great!
Be aware of the API client package:
https://godoc.org/github.com/prometheus/client_golang/api/prometheus

I've recently been thinking about kicking out the dependency on the model
package. But with vendoring those potential changes are not blocking.

On Wed, Jun 1, 2016 at 4:59 PM Ali Reza notifications@github.com wrote:

Nice, i guess i'll try to start working on this.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1605 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEuA8m5hYbWFZlvLgDddiowJMbmcSU6Gks5qHZ46gaJpZM4IStvv
.

@alileza

This comment has been minimized.

Copy link
Contributor

alileza commented Jun 2, 2016

Ok, so basically we want to move prometheus_cli features into promtool using client_golang api?

hmm, also about model what do you mean by not blocking?

@alileza

This comment has been minimized.

Copy link
Contributor

alileza commented Jun 12, 2016

is this changes is what we expect on promtool? if it is, i'll continue to work on query_range etc and submit at PR.
alileza@36da400

@beorn7

This comment has been minimized.

Copy link
Member Author

beorn7 commented Jun 13, 2016

Sorry, dropped the ball here. Yes, this all sounds good to me. What @fabxc tried to say about the prometheus/common/model dependency is essentially "don't worry". @fabxc Please shout if there is anything else to say at this point.

@xmudrii

This comment has been minimized.

Copy link

xmudrii commented Sep 30, 2017

What's the status of this issue?
I saw the Hacktoberfest label and I want to start contributing to the Prometheus project.

If this is still needed I would love to try fixing this one. Also if there are some instructions/guidelines I would appreciate them.

@brancz

This comment has been minimized.

Copy link
Member

brancz commented Oct 2, 2017

Not sure how far we want to go with this, but for a quickstart I threw this together a while ago, and just queried further with jq. It's not much, but it's a start https://gist.github.com/brancz/1c252d4c87a48c80df7c6b046823c466

Questions we may want to ask ourselves is, which format(s) do we want to output? Interactive? One-off?

Personally I don't think this needs any dependency on common/model, but that also somewhat depends on what we want to build here.

@si74

This comment has been minimized.

Copy link
Contributor

si74 commented Apr 1, 2018

Hey! I'd be interested working on this.

@krasi-georgiev

This comment has been minimized.

Copy link
Member

krasi-georgiev commented Aug 1, 2018

based on the original issue this is now fixed

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.