handle remote storage openTSDB error response correctly.

[guanglinlv]

Hi folks,

when then openTSDB return a error response with 400 status code. it looks like the following with different request:

• /api/put

{
   "error" : {
         "code": 400,
         "details": "Please seen the TSD logs or append \"details\" to the put request",
         "message": "one or more data points had errors",
         "trace": ".........."
    }
}

• /api/put?summary

{
    "failed": 1,
    "success": 1
}

i think the second output is what we need. otherwise the client.go#L127 will report a error. we should change the putEndpoint const to /api/put?summary.

more details on /api/put, see http://opentsdb.net/docs/build/html/api_http/put.html

thanks.

[guanglinlv]

aha, it is not need to change the putEndpoint, i can set the prometheus -storage.remote.opentsdb-url=http://opentsdb-host:4242/?summary , then opentsdb's response is

HTTP/1.1 200 OK
.
{
    "failed": 0,
    "success": 100
}

however, client.go#L115 compare the status code with 204. actually it is 200.

then, a incorrect error will report at queue_manager.go#L194-L198

[brian-brazil]

See also #1061

[grobie]

OpenTSDB support has been removed. Use a remote storage adapter.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.