Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove notifier metrics #1630
Comments
brian-brazil
added
the
kind/enhancement
label
May 13, 2016
brian-brazil
added this to the v1.0.0 milestone
May 13, 2016
This comment has been minimized.
This comment has been minimized.
|
Am I missing something or is this actually fixed? |
This comment has been minimized.
This comment has been minimized.
|
Doesn't seem to be fixed. |
This comment has been minimized.
This comment has been minimized.
|
Well... could you please point to where you think it is not? I'm looking at this piece of code: https://github.com/prometheus/prometheus/blob/master/notifier/notifier.go#L291-L297 |
This comment has been minimized.
This comment has been minimized.
|
Looks like I misread the code, all good. |
brian-brazil
closed this
Jun 23, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
brian-brazil commentedMay 13, 2016
Per our standard guidelines
prometheus_notifications_latency_secondsshould include failed notifications andprometheus_notifications_sent_totalshould include failures.