Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy JSON format support #1640

Closed
fabxc opened this Issue May 18, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@fabxc
Copy link
Member

fabxc commented May 18, 2016

This would mostly affect the common/expfmt library but the feature would be visible in Prometheus.
@beorn7, so the last status was that this really only affects SC internals, no?

In that case we should drop that baggage for 1.0.
I might recall incorrectly though and there were other uses that justified keeping it again and again.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented May 18, 2016

I might recall incorrectly though and there were other uses that justified keeping it again and again.

I was under the impression it was only SC.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented May 18, 2016

Somebody was still using the old JMX exporter, but that should be gone now. Perhaps there are remnants in Ruby clients, but I don't think any of those justify blocking it. Deprecation announcement is ages ago.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented May 18, 2016

Support for JSON format in ruby client was dropped in release 0.5.0 / 2016-01-02.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented May 20, 2016

So let's drop this for 0.19?

(But then we should do it really soon to not delay 0.19 any further.)

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented May 24, 2016

Or perhaps let's make 0.19 the last release that still supports the old format, as a last deprecation warning. (Also, it allows us to release 0.19 ~now. I really want to see the recent bug fixes released as we are running into those bugs pretty frequently.)

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented May 24, 2016

I'd prefer to avoid breaking changes in 1.0, but I don't feel too strongly on this one.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented May 24, 2016

We have kept json around for so long, I don't see a need to remove it before 1.0 either.

@fabxc fabxc added this to the v1.0.0 milestone May 24, 2016

@fabxc fabxc closed this Jun 23, 2016

@fabxc fabxc reopened this Jun 23, 2016

@fabxc fabxc closed this Jun 23, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.