Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop legacy JSON format support #1640
Comments
fabxc
added
dependency/external
priority/P1
labels
May 18, 2016
This comment has been minimized.
This comment has been minimized.
I was under the impression it was only SC. |
This comment has been minimized.
This comment has been minimized.
|
Somebody was still using the old JMX exporter, but that should be gone now. Perhaps there are remnants in Ruby clients, but I don't think any of those justify blocking it. Deprecation announcement is ages ago. |
This comment has been minimized.
This comment has been minimized.
|
Support for JSON format in ruby client was dropped in release 0.5.0 / 2016-01-02. |
This comment has been minimized.
This comment has been minimized.
|
So let's drop this for 0.19? (But then we should do it really soon to not delay 0.19 any further.) |
This comment has been minimized.
This comment has been minimized.
|
Or perhaps let's make 0.19 the last release that still supports the old format, as a last deprecation warning. (Also, it allows us to release 0.19 ~now. I really want to see the recent bug fixes released as we are running into those bugs pretty frequently.) |
This comment has been minimized.
This comment has been minimized.
|
I'd prefer to avoid breaking changes in 1.0, but I don't feel too strongly on this one. |
This comment has been minimized.
This comment has been minimized.
|
We have kept json around for so long, I don't see a need to remove it before 1.0 either. |
fabxc
added this to the v1.0.0 milestone
May 24, 2016
fabxc
closed this
Jun 23, 2016
fabxc
reopened this
Jun 23, 2016
fabxc
closed this
Jun 23, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fabxc commentedMay 18, 2016
This would mostly affect the
common/expfmtlibrary but the feature would be visible in Prometheus.@beorn7, so the last status was that this really only affects SC internals, no?
In that case we should drop that baggage for 1.0.
I might recall incorrectly though and there were other uses that justified keeping it again and again.