Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upLog HTTP server errors using common/log #1651
Comments
grobie
added
low hanging fruit
kind/enhancement
labels
May 24, 2016
This comment has been minimized.
This comment has been minimized.
|
@alileza Want to give this a try as a beginner issue? |
This comment has been minimized.
This comment has been minimized.
|
The only tricky part is that log.Logger isn't an interface but a struct (grrr golang). Possible implementation could use a buffer as output of the ErrorLog logger, and then read from that logger and call our log function. Given the critical context, we'll need to be sure that this doesn't introduce (too many) new failure cases. |
This comment has been minimized.
This comment has been minimized.
|
@juliusv ah sure i'll working on it |
alileza
added a commit
to alileza/prometheus
that referenced
this issue
May 26, 2016
juliusv
closed this
in
#1660
May 26, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
grobie commentedMay 24, 2016
We currently don't set
ErrorLogon the HTTP server, which means that critical errors are being logged using the standard logger instead of the user configurable common/log. See https://golang.org/pkg/net/http/#Server@mrwacky42