Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar is broken in Safari #1659

Closed
hynek opened this Issue May 25, 2016 · 9 comments

Comments

Projects
None yet
5 participants
@hynek
Copy link

hynek commented May 25, 2016

Since 0.19.0, both in regular Safari of OS X 10.11.5 and Safari Tech Preview, the navbar breaks as if the windows were too narrow:

2016-05-25 at 10 00

Relatedly, such a broken navbar (which I assume is intended on mobile) overlaps top content of the page. In this case the title “Runtime Information”.

Works fine on Chrome 51.0.2704.54 beta and Firefox 45.0b6.

@guanglinlv

This comment has been minimized.

Copy link

guanglinlv commented May 25, 2016

+1, chrome/35

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented May 25, 2016

Ugh… Somehow, a spurious “w” made it into _base.html. See #1661

@hynek Can you verify it fixes the problem?

If yes, we need to cut 0.19.1 ;(

Perhaps wait until tomorrow to see if other snafus like this show up...

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented May 25, 2016

Got hold of a Mac. Verified that this is fixed indeed.

So, when to cut 0.19.1? :-/

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented May 25, 2016

I'd give it a day or two. This isn't a critical issue so we can wait in case something else comes up.

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented May 25, 2016

Funny enough, it only shows up in Safari and not in Chrome on the Mac I tried. @guanglinlv seems to have a different Chrome version.

@hynek

This comment has been minimized.

Copy link
Author

hynek commented May 25, 2016

Great, thanks for fixing! Right now I’m in a whirlwind of conf&travel preparations & can’t do much to help you.

@guanglinlv

This comment has been minimized.

Copy link

guanglinlv commented May 26, 2016

@beorn7 👍 👍 yes,my chrome version is 35 in my lab , it's a little lower. it work fine with your fix.

thanks.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 26, 2016

FTR 0.19.1 is already cut due to another critical bug – binary and container builds in progress.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.