Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop suite of standard Prometheus benchmarks #168

Closed
juliusv opened this Issue Apr 21, 2013 · 9 comments

Comments

Projects
None yet
5 participants
@juliusv
Copy link
Member

juliusv commented Apr 21, 2013

We should develop and maintain a suite of easy-to-run Prometheus benchmarks that make it easy for us to compare the performance of different Prometheus versions and configurations.

Possible variables to vary in the benchmark:

  • value of GOMAXPROCS
  • general fulness of metrics database
  • number of timeseries
  • number of samples per timeseries
  • ratio of samples in memory vs. disk
  • query resolutions
  • parallelism of queries
  • Prometheus version

What to benchmark:

  • point / range query times
  • scraping / decoding / appending samples times
@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Apr 17, 2015

Not quite. Those benchmarks were executed "manually", by running a Prometheus server hotter and hotter until it broke. It hardly qualifies as "easy-to-run". There is https://github.com/prometheus/prometheus/blob/master/storage/local/storage_test.go#L711-L721 , which covers quite a lot in the storage layer, but has no knobs to turn and is not very specific.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 7, 2017

Can we close this now with prombench?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jul 7, 2017

@gouthamve

This comment has been minimized.

Copy link
Member

gouthamve commented Jul 7, 2017

Hmm, I don't think so. We still don't have something to evaluate against. I mean, do we have a clear system to recognise regressions?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jul 7, 2017

Yes, there's stuff missing. But I think we should close here and file them in prombench.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 7, 2017

I agree with Fabian.

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented Jul 7, 2017

@juliusv juliusv closed this Jul 8, 2017

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.