Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rules_files and file_sd names consistent. #1682

Closed
brian-brazil opened this Issue May 28, 2016 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  v1.0.0
1 participant
@brian-brazil
@brian-brazil
Copy link
Member

brian-brazil commented May 28, 2016

For the rules files we call the config parameter rules_files, whereas for file_sd we also have a list of globals to files and call it names.

For consistency I propose that we rename the file_sd parameter to files or similar.

@brian-brazil brian-brazil added the kind/friction label May 28, 2016

@brian-brazil brian-brazil added this to the v1.0.0 milestone May 28, 2016

@alileza alileza referenced this issue May 29, 2016

Merged

change file_sd names to files, for consistency #1686

@fabxc fabxc closed this in #1686 Jun 1, 2016

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.