Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `target_groups` to `static_configs` #1706

Closed
fabxc opened this Issue Jun 6, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@fabxc
Copy link
Member

fabxc commented Jun 6, 2016

Our SD configurations are consistently suffixed with _configs and descriptive of what they do. target_groups seems out of order.
I'd suggest renaming it to static_configs as we have a break to configuration with the recent changes in file SD configs anyway.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jun 6, 2016

That's going to be a painful one, but I think it makes sense. We might want to do it gracefully.

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Jun 7, 2016

+1 for the consolidation. Following our discussion of the alert syntax
changes, I think this should be done in 3 release steps.

  1. Introduce new naming, still accept old naming, print a descriptive
    warning.
  2. Remove old naming, print a descriptive error message explaining what to
    change.
  3. Remove error handling of old naming.

On Mon, Jun 6, 2016 at 2:09 PM, Brian Brazil notifications@github.com
wrote:

That's going to be a painful one, but I think it makes sense. We might
want to do it gracefully.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1706 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAANaMB80l5mdVumEvDDUS8PwlYU3IO7ks5qJA3sgaJpZM4Iu08a
.

@fabxc

This comment has been minimized.

Copy link
Member Author

fabxc commented Jun 8, 2016

Fixed via #1716

@fabxc fabxc closed this Jun 8, 2016

gianrubio added a commit to gianrubio/graylog-plugin-metrics-reporter that referenced this issue Feb 24, 2017

joschi added a commit to graylog-labs/graylog-plugin-metrics-reporter that referenced this issue Mar 14, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.