Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRename `target_groups` to `static_configs` #1706
Comments
fabxc
added
area/usability
component/config
labels
Jun 6, 2016
brian-brazil
added this to the v1.0.0 milestone
Jun 6, 2016
This comment has been minimized.
This comment has been minimized.
|
That's going to be a painful one, but I think it makes sense. We might want to do it gracefully. |
This comment has been minimized.
This comment has been minimized.
|
+1 for the consolidation. Following our discussion of the alert syntax
On Mon, Jun 6, 2016 at 2:09 PM, Brian Brazil notifications@github.com
|
This comment has been minimized.
This comment has been minimized.
|
Fixed via #1716 |
fabxc
closed this
Jun 8, 2016
gianrubio
added a commit
to gianrubio/graylog-plugin-metrics-reporter
that referenced
this issue
Feb 24, 2017
gianrubio
referenced this issue
Feb 24, 2017
Merged
Rename target_groups to static_configs in the example #18
joschi
added a commit
to graylog-labs/graylog-plugin-metrics-reporter
that referenced
this issue
Mar 14, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fabxc commentedJun 6, 2016
•
edited by brian-brazil
Our SD configurations are consistently suffixed with
_configsand descriptive of what they do.target_groupsseems out of order.I'd suggest renaming it to
static_configsas we have a break to configuration with the recent changes in file SD configs anyway.