Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marathon SD assumes all applications have a port. #1711

Closed
rdacquisto opened this Issue Jun 6, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@rdacquisto
Copy link

rdacquisto commented Jun 6, 2016

The following line is throwing a panic:

return fmt.Sprintf("%s:%d", task.Host, task.Ports[0])

This is because task.Ports[0] assumes a length greater than 0, but the marathon configuration for the app is as follows:

  "portDefinitions": [
  ],

There appears to be a bad assumption that all apps will have ports.

The app that is causing this error is marathon-lb.

The work around is to add a random port definition, but this isn't ideal.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jun 14, 2016

@fabxc fabxc closed this Jun 14, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.