Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up"./prometheus -h" should not include test flags #1743
Comments
fabxc
added a commit
that referenced
this issue
Jul 3, 2016
beorn7
referenced this issue
Jul 3, 2016
Closed
promql: Holt-Winters benchmark does not detect failures. #1784
fabxc
closed this
in
#1782
Jul 4, 2016
tomwilkie
referenced this issue
Jul 25, 2018
Merged
Don't import testing in code which is imported from non-test code. #4400
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
juliusv commentedJun 15, 2016
Prometheus includes
-test...flags in the output of./prometheus -h. This is because this PR is pulling in packagetestinginto the main binary viabench.go: #1485. That shouldn't happen.I'm going to move the benchmarking-related code purely into
*_test.gosince it's only used from there and it's also not clear whether we should be making it part of the general package yet (likeTest).However, while doing that, I also noticed that the Holt Winters benchmarks actually fail, but that the error return value is ignored (https://github.com/prometheus/prometheus/blob/master/promql/bench.go#L42) :( I guess that's one way of tuning benchmarks :) I'll remark that on #1485 to see how to proceed.