Alerts should be relabelable

[brian-brazil]

Before sending alerts out you should have a chance to relabel them. Use cases include having a different external label on a HA pair that you want to strip so that the alertmanager will de-dupe them, and having alerts that are only used as part of ALERTS for other alerts and shouldn't be sent to the alertmanager.

Only labels would be relabelable, not annotations. ALERTS is not affected.

[aecolley]

What labels can prevent an alert from being sent to alertmanagers? I traced the path back from notifier's POST to sendAlerts in rules/manager.go but didn't find any label-related filtering.

[brian-brazil]

This issue is about implementing such support.

[brancz]

@brian-brazil is this not fixed with #1878 ? If not can you elaborate?

[brian-brazil]

Relabelling should be after external labels, not before.

[brancz]

Ok that makes sense. If I understand correctly, we just need to move this before relabelling?

[brian-brazil]

Yes

[brancz]

PR on it's way

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.