[Feature Request] Put full Git commit id in prometheus_build_info's revision label

[RichiH]

As per subject; the extra storage is neglible and as humans don't need to type the string, it's better to use longform.

[juliusv]

Does this have any real advantages? I can only see how it would make things like dashboards showing this information require more space.

[RichiH]

Arguably, the UI should take care of UI considerations.

The backend should be as explicit as possible.

[juliusv]

Fine with me.

[vic3lord]

This is something that needs to be changed on prometheus/promu and not here, am I wrong?

[sdurrheimer]

promu is involved in this change yes, but we also might need to do changes in prometheus/common/version depending of the way of implementing it.

[vic3lord]

Let me know if I can do anything to help, really love this project I'd love to spend sometime on it even though it's a small thing

[sdurrheimer]

We can change the Revision prop here to store the full git revision.
But then we might need to change commandline outputs of the prometheus/common/version package here and here to display only the short version. I don't how the commandline output would look like with a full git revision.

[vic3lord]

We can add short-revision property and use both each when its needed

[sdurrheimer]

I don't think we need to add a prop to store a semi-duplicated data. We can computes it, since a short-revision corresponds to the first seven characters.

[vic3lord]

Great so just [:7] is enough

On 26 Jul 2016, at 15:19, Steve Durrheimer notifications@github.com wrote:

I don't think we need to add a prop to store a semi-duplicated data. We can computes it, since a short-revision corresponds to the first seven characters.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #1748 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ACwA8MKfgymZJmPA9FKy6TYQR18PtqYZks5qZftegaJpZM4I4Jaa.

[grobie]

Nitpick, but git rev-parse --short HEAD is not guaranteed to return seven characters. That's the default minimum value of the --short flag, but in general git will return the shortest unambigious sha1 prefix. In theory these could also be more than 7 characters at some point.

[RichiH]

And if it prints seven today, it might print ten tomorrow. That is part of why I would use longform for all the things. Richard Sent by mobile; excuse my brevity.

[fabxc]

👍 on using the full one. When selecting along that dimension we are still free to do =~"abcdef12.*". No one loses really.

[sdurrheimer]

PR open on Promu's repo to make the change.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.