Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uppromql: Holt-Winters benchmark does not detect failures. #1784
Comments
beorn7
added
area/testing
priority/P2
component/promql
labels
Jul 3, 2016
beorn7
self-assigned this
Aug 24, 2016
beorn7
referenced this issue
Aug 24, 2016
Merged
promql: Fix (and simplify) populating iterators #1917
beorn7
closed this
Aug 26, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
beorn7 commentedJul 3, 2016
From #1743 :
"However, while doing that, I also noticed that the Holt Winters benchmarks actually fail, but that the error return value is ignored (https://github.com/prometheus/prometheus/blob/master/promql/bench.go#L42) :( I guess that's one way of tuning benchmarks :) I'll remark that on #1485 to see how to proceed."
This needs to be fixed. @eliothedeman would be great if you could provide context or even a fix.