Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promql: Holt-Winters benchmark does not detect failures. #1784

Closed
beorn7 opened this Issue Jul 3, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@beorn7
Copy link
Member

beorn7 commented Jul 3, 2016

From #1743 :
"However, while doing that, I also noticed that the Holt Winters benchmarks actually fail, but that the error return value is ignored (https://github.com/prometheus/prometheus/blob/master/promql/bench.go#L42) :( I guess that's one way of tuning benchmarks :) I'll remark that on #1485 to see how to proceed."

This needs to be fixed. @eliothedeman would be great if you could provide context or even a fix.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.