Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor `aggregation` in engine.go #1789

Open
brian-brazil opened this Issue Jul 5, 2016 · 4 comments

Comments

Assignees
No one assigned
Labels
component/promql hacktoberfest help wanted kind/cleanup priority/P3
Projects
None yet
Milestone
No milestone
4 participants
@brian-brazil @serathius @krasi-georgiev @gouthamve
@brian-brazil
Copy link
Member

brian-brazil commented Jul 5, 2016

This function is getting complicated, some cleanup would be good.

@brian-brazil brian-brazil added the kind/cleanup label Jul 5, 2016

@brian-brazil brian-brazil referenced this issue Jul 5, 2016

Merged

Make topk/bottomk aggregators. #1788

@brian-brazil brian-brazil added priority/P3 help wanted component/promql labels Jul 14, 2017

@gouthamve gouthamve added the hacktoberfest label Sep 28, 2017

@serathius

This comment has been minimized.

Sign in to view
Copy link
Contributor

serathius commented Mar 14, 2018

Is it ok for me to take it?
I will prepare some tests before refactoring.
@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member Author

brian-brazil commented Mar 14, 2018

I'm in the middle of redoing large portions of PromQL, so I'd hold off. We already have pretty good tests for PromQL.
@krasi-georgiev

This comment has been minimized.

Sign in to view
Copy link
Member

krasi-georgiev commented Aug 14, 2018

@brian-brazil was this done in the promql refactoring?
@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member Author

brian-brazil commented Aug 14, 2018

No, I didn't change this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.