Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the quantile line of prometheus_remote_storage_send_latency_seconds has a wrong value. #1796

Closed
guanglinlv opened this Issue Jul 7, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@guanglinlv
Copy link

guanglinlv commented Jul 7, 2016

What did you do?

config the --storage.remote.timeout to 5s, keep the prometheus running, take a look the prometheus_remote_storage_send_latency_seconds.

What did you expect to see?

any line of prometheus_remote_storage_send_latency_seconds has a value between 0 and 5s

What did you see instead? Under which circumstances?

the quantile=0.99 line has a value from 1 to 6s.

1

Environment

  • System information:

    Linux 3.10.0-229.el7.x86_64 x86_64

  • Prometheus version:

    prometheus, version 0.20.0 (branch: master, revision: aeab25c)
    build user:       root@77050118f904
    build date:       20160616-08:38:14
    go version:       go1.6.2
    
@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Jul 7, 2016

The baseline might be right, but the problem here is the rounding to full seconds.

I'll fix the latter, and then we'll see how the baseline looks then.

beorn7 added a commit that referenced this issue Jul 7, 2016

Consistently use the `Seconds()` method for conversion of durations
This also fixes one remaining case of recording integral numbers
of seconds only for a metric, i.e. this will probably fix #1796.

@fabxc fabxc closed this in #1797 Jul 7, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.