Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goroutine Leak #180

Closed
matttproud opened this Issue Apr 24, 2013 · 2 comments

Comments

Assignees

@discordianfish discordianfish

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@matttproud @discordianfish
@matttproud
Copy link
Member

matttproud commented Apr 24, 2013

This should be easy to fix and would be a good learning experience for the Prometheus core code.

This goroutine is being leaked in tests:
https://github.com/prometheus/prometheus/blob/master/storage/metric/tiered.go#L169

Upon draining https://github.com/prometheus/prometheus/blob/master/storage/metric/tiered.go#L187, it should end.

@ghost ghost assigned discordianfish Apr 24, 2013

@matttproud matttproud referenced this issue Apr 24, 2013

Merged

Include generated Protocol Buffer descriptor. #179

@discordianfish discordianfish referenced this issue Apr 25, 2013

Merged

Have goroutine exit on signal via defer block. #187

@matttproud

This comment has been minimized.

Sign in to view
Copy link
Member Author

matttproud commented Apr 25, 2013

Fixed. :-)

@matttproud matttproud closed this Apr 25, 2013

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.