Kubernetes SD example does not include required 'role'

[karora]

From the 1.0 release notes, as well as from reading the documentation here:
https://github.com/prometheus/docs/blob/master/content/docs/operating/configuration.md#kubernetes_sd_config

it appears that a role of endpoint, service, node, pod, container or apiserver must be present in each kubernetes_sd_config, however the example does not yet seem to be updated to include these.

https://github.com/prometheus/prometheus/blob/master/documentation/examples/prometheus-kubernetes.yml

[jimmidyson]

Good catch. Fancy sending in a PR to fix?

[karora]

Heh - there was a reason I was looking for the example - might take me a week or two before I have the time to read and understand the manual - it's pretty dense prose ... :-)

[SleepyBrett]

Yeah this broke my install as well.

So I'm reading your documentation and trying to reconcile it with the example config (which is almost identical to my deployed config at this point).

It's not at all clear which role I should chose for each current scrape job you have defined. For instance the first job (kubernetes-cluster) claims to scrape for the cluster components including api server and node.. so which role, apiserver or node?

The very next scrape claims to scrape service endpoints.. so role: service or endpoint?

There is no documentation that I can find on what each value of role does other than "it has to be one of these values".

So maybe someone in the know can update this: https://prometheus.io/docs/operating/configuration/

[SleepyBrett]

Well I was just about to build a pull request around my first stab at a config and it looks like you guys have a new config example on master.

thanks @zoidbergwill

[zoidbergwill]

Whoops, didn't even see this issue, or I would've referenced it in my PR.

Fortunately the great people that reviewed my PR managed to help me figure out what exactly needed to be updated.

[jimmidyson]

Fixed by #1840

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.