Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename series API #1870

Closed
qed- opened this Issue Aug 3, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@qed-
Copy link

qed- commented Aug 3, 2016

It would be very useful to have a way to rename series via the HTTP API.
Ideally this would also allow retrospectively adding a label to a series, and merging with any existing series that has the same name/labels.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Aug 3, 2016

I don't think this is something we'd offer directly, rather it'd be built as a tool on top of deleting and #535 backfill.

@qed-

This comment has been minimized.

Copy link
Author

qed- commented Aug 4, 2016

Isn't that approach a bit heavy handed?
I'd have thought it would be reasonably simple to modify the metadata describing a series (and update any indexes etc.) rather than copy the entire series.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Aug 4, 2016

Realistically, doing this in flight seems to be a very rare use case and
comes with a lot of complications. Updating an index is not always trivial.
With the current one it would actually work. With a more sophisticated one,
one would probably prefer to modify the past at all cost due to complexity.

It also means a) that you are still getting new samples for the old series
name and hence it gets recreated immediately or b) that the series is
already renamed in the scrape targets and now you have to shuffle around on
disk a lot to actually get new samples aligned with the old, now renamed,
sample stream.

At the cost/benefit scale this feature just performs really badly,
unfortunately.

On Thu, Aug 4, 2016 at 2:30 PM David Chapman notifications@github.com
wrote:

Isn't that approach a bit heavy handed?
I'd have thought it would be reasonably simple to modify the metadata
describing a series (and update any indexes etc.) rather than copy the
entire series.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1870 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuA8k3YFt3J-zfoUACMbo97DDbTi-Onks5qcdtvgaJpZM4Jbv5X
.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Aug 5, 2016

Closing this due to the reasons above. We might be able to reconsider at some point but currently it doesn't seem feasible.

@fabxc fabxc closed this Aug 5, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.