Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relabelling to generic write path #1955

Closed
brian-brazil opened this Issue Sep 7, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@brian-brazil
Copy link
Member

brian-brazil commented Sep 7, 2016

As with alerting, this goes after external labels are applied. Where should we put this in the config?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Sep 7, 2016

Probably it's own section for all related config. We probably also want to
have SD in there to discover write targets?

On Wed, Sep 7, 2016 at 11:27 AM Brian Brazil notifications@github.com
wrote:

As with alerting, this goes after external labels are applied. Where
should we put this in the config?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1955, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuA8vzeiH2VqkoVBo6yjH1-Ln9g57yLks5qnoNsgaJpZM4J2tuE
.

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Sep 7, 2016

Yeah, we'll probably ultimately want that. We're still on "target" right now :)

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Sep 7, 2016

Yes, just another reason to have a new top-level section for remote as
there'll be more coming.
That might be best divided in read and write again.

On Wed, Sep 7, 2016 at 11:46 AM Brian Brazil notifications@github.com
wrote:

Yeah, we'll probably ultimately want that. We're still on "target" right
now :)


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#1955 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuA8oSFrP-EZdrslhY6S_Xbu9Kzy0C4ks5qnofhgaJpZM4J2tuE
.

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Sep 7, 2016

I've have separate top-level write and read sections.

@tomwilkie

This comment has been minimized.

Copy link
Member

tomwilkie commented Sep 7, 2016

Will also want to include remote auth in the config, see #1957.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.