Failing test

[TheTincho]

Hi,

When building prometheus 1.1.1 for Debian, I have one test failing:

=== RUN   TestTargetSetRecreatesTargetGroupsEveryRun
time="2016-09-08T09:01:12Z" level=error msg="Error refreshing DNS targets: could
 not resolve srv.name.one.example.org: No server responded" source="dns.go:118" 
--- FAIL: TestTargetSetRecreatesTargetGroupsEveryRun (5.00s)
        targetmanager_test.go:36: 'dns/0/srv.name.one.example.org' should be present in TargetSet.tgroups: map[]

FAIL
exit status 1
FAIL    github.com/prometheus/prometheus/retrieval      8.587s

I don't know if this is really trying to access the network or not. In any case, it is a problem: Debian builds are forbidden from trying to access the network at all.

This is running with golang 1.7

[beorn7]

Perhaps the test wants the negative response from the network that srv.name.one.example.org doesn't exist.

And yes, that's something we should avoid.

[grobie]

@dmilstein it seems you added that test. Do you have time to rewrite it to not depend on a internet connection / working DNS discovery?

[dmilstein]

Drat, didn't realize it was actually resolving. Yep, I'll take a look and fix that.

Sorry about that,
D

iPhone brevity in effect

On Sep 8, 2016, at 4:02 PM, Tobias Schmidt notifications@github.com wrote:

@dmilstein it seems you added that test. Do you have time to rewrite it to not depend on a internet connection / working DNS discovery?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[grobie]

Fixed with #1966

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.