Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation endpoint does not comply with the exposition format specification #1963

Closed
beorn7 opened this Issue Sep 8, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@beorn7
Copy link
Member

beorn7 commented Sep 8, 2016

Currently, the federation endpoint exposes one MetricFamily for each time series, thus duplicating a lot of information.

While Prometheus ingests such duplicated MetricFamilies just fine in protobuf format, the text format spec is less lenient about the duplication. Since the text format creator in the expfmt package faithfully translates the duplicated MetricFamilies, the text format output is currently not valid.

We might make it valid, see prometheus/common#54 , but we should also investigate the cost/benefit ratio for collapsing the MetricFamily in federation (saves network bandwidth and the cost of (de-)compression and decoding).

@beorn7 beorn7 added the kind/bug label Sep 8, 2016

@beorn7 beorn7 self-assigned this Sep 8, 2016

@beorn7 beorn7 changed the title Federation: Consider collapsing output Federation endpoint does not comply with the exposition format specification Sep 9, 2016

@beorn7

This comment has been minimized.

Copy link
Member Author

beorn7 commented Sep 9, 2016

I had another look at the spec. The protobuf spec is actually as strict as the text format spec WRT repeated metric names: "Each MetricFamily within the same exposition must have a unique name."

So it's a bug even on the protobuf level.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.