Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFederation endpoint does not comply with the exposition format specification #1963
Comments
beorn7
added
the
kind/bug
label
Sep 8, 2016
beorn7
self-assigned this
Sep 8, 2016
beorn7
referenced this issue
Sep 8, 2016
Merged
federation: Collapse time series of the same name #1965
beorn7
changed the title
Federation: Consider collapsing output
Federation endpoint does not comply with the exposition format specification
Sep 9, 2016
This comment has been minimized.
This comment has been minimized.
|
I had another look at the spec. The protobuf spec is actually as strict as the text format spec WRT repeated metric names: "Each MetricFamily within the same exposition must have a unique name." So it's a bug even on the protobuf level. |
beorn7
referenced this issue
Sep 9, 2016
Open
exposition format: How to deal with duplicate metric families #547
beorn7
closed this
Sep 16, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
beorn7 commentedSep 8, 2016
Currently, the federation endpoint exposes one MetricFamily for each time series, thus duplicating a lot of information.
While Prometheus ingests such duplicated MetricFamilies just fine in protobuf format, the text format spec is less lenient about the duplication. Since the text format creator in the expfmt package faithfully translates the duplicated MetricFamilies, the text format output is currently not valid.
We might make it valid, see prometheus/common#54 , but we should also investigate the cost/benefit ratio for collapsing the MetricFamily in federation (saves network bandwidth and the cost of (de-)compression and decoding).