Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting TLS renegotiation #1998

Open
vipetrul opened this Issue Sep 15, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@vipetrul
Copy link

vipetrul commented Sep 15, 2016

It appears that when HTTPS endpoint has TLS renegotiation enabled, then Prometheus receives "local error: no renegotiation" error upon scraping.

It is OK if HTTPS endpoint is using TLS 1 protocol, as long as TLS renegotiation is disabled on the server.

Golang version. 1.6

No action is needed on this ticket, just wanted to report observed behavior.
Unfortunately underlying issue with TLS renegotiation was fixed, hence I cannot provide you with a link to a live example.

@jimmidyson

This comment has been minimized.

Copy link
Member

jimmidyson commented Sep 15, 2016

Looks like it should be in go 1.7 - golang/go#5742

@grobie

This comment has been minimized.

Copy link
Member

grobie commented Sep 15, 2016

Weve had a long discussion about this last night, I found and suggested the same and tried scraping the problematic URL with a go1.7 compiled prometheus server and got the same reponse local error: no renegotiation.

@brian-brazil brian-brazil changed the title Problem with scraping metrics from HTTPS endpoint (TLS) Consider supporting TLS renegotiation Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.