Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly allow single K8S API server in SD config #2013
Comments
This comment has been minimized.
This comment has been minimized.
|
If that's the way the upstream API works, then that's the way it works. |
This comment has been minimized.
This comment has been minimized.
|
OK let's go with that. Needs to be noted that as we move to static configuration for API servers to scrape metrics from (not k8s SD) that users will have to configure all the API servers, not just the RR DNS or proxy address, but that's a separate issue. |
This comment has been minimized.
This comment has been minimized.
|
The new k8 SD does this. |
brian-brazil
closed this
Oct 26, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
fabxc commentedSep 21, 2016
The Kubernetes upstream client library does not support multiple API server URLs but instead expects DNS load balancing or using a proxy:
https://godoc.org/k8s.io/client-go/1.4/rest#Config
We should consider making the K8S SD config argument just a single API server URL. If we want to use the official client library there's no way to use multiple ones. With cluster federation and all, there's a fair bit of proxying involved behind the scenes anyway.
@brian-brazil @jimmidyson