Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether queue reporting should be adapted for new array-based channels #206

Closed
juliusv opened this Issue Apr 29, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@juliusv
Copy link
Member

juliusv commented Apr 29, 2013

/cc @matttproud we still only report the length/capacity of the queue channels, not how many samples each sample array in the channel contains. Should the exported value still show the total amount of samples in the channel? Then we have to change how reporting works, because we can't peek into the channel and count subelements without removing elements from the channel.

@matttproud

This comment has been minimized.

Copy link
Member

matttproud commented Apr 29, 2013

I am OK with purely the queue capacity and occupancy. That is fundamentally the bottleneck.

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented Apr 29, 2013

Ok, cool. Closing this then.

@juliusv juliusv closed this Apr 29, 2013

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.