Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter the instance label in the targets page #2061

Closed
grobie opened this Issue Oct 7, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@grobie
Copy link
Member

grobie commented Oct 7, 2016

At least when relabeling is used to set the instance label (see http://www.robustperception.io/controlling-the-instance-label/) we should not filter the instance label from the targets page overview. Any objections to just always show it?

{{$labels := stripLabels .Labels "job" "instance"}}

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Oct 7, 2016

Agreed, lets always show it.

matthiasr added a commit to matthiasr/prometheus that referenced this issue Oct 7, 2016

Always show instance label on target page.
It may be different from the address shown in the first column.

Closes prometheus#2061.

@grobie grobie closed this in #2062 Oct 12, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.