Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect logic in file sd? #2104

Closed
brian-brazil opened this Issue Oct 21, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@brian-brazil
@brian-brazil
Copy link
Member

brian-brazil commented Oct 21, 2016

https://github.com/dominikschulz/prometheus/blob/23a20b591e44a4b2abf3ed4e4fe91ec25f3cc1d7/retrieval/discovery/file.go#L145 seems wrong, I think that should be an & rather than a ^.
@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member Author

brian-brazil commented Oct 26, 2016

This isn't easy logic to understand, but working through the truth tables this seems to have the right behaviour.

@brian-brazil brian-brazil closed this Oct 26, 2016

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.