Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support http/2 #2124

Closed
ZeeShen opened this Issue Oct 27, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@ZeeShen
Copy link

ZeeShen commented Oct 27, 2016

Do you have any plan to support scrape metrics via http/2?
For grpc servers, it will be convenient to expose a metrics interface in http/2.

@hwinkel

This comment has been minimized.

Copy link

hwinkel commented Nov 5, 2016

so unify CNCF APIs towards HTTP/2 ?

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Nov 5, 2016

Does Prometheus not support HTTP/2 already? It was my understanding that starting with Go 1.6, the standard library HTTP server transparently did HTTP/2 when needed. Local tests seem to confirm this against the https://http2.golang.org/ test server.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Nov 5, 2016

That's matches my latest state of knowledge.
Did you try it out and found it not working?

On Sat, Nov 5, 2016 at 2:46 PM Julius Volz notifications@github.com wrote:

Does Prometheus not support HTTP/2 already? It was my understanding that
starting with Go 1.6, the standard library HTTP server transparently did
HTTP/2 when needed. Local tests seem to confirm this against the
https://http2.golang.org/ test server.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2124 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuA8pIrwHLrznesBpOfgvitiMgelQJbks5q7PkkgaJpZM4Kh_Nj
.

@ZeeShen

This comment has been minimized.

Copy link
Author

ZeeShen commented Nov 7, 2016

Maybe I should change issue to best practice to export metrics from grpc server?. The problems I've had:

  1. Grpc server doesn't support Get, but scrape request is via get
  2. How to define metrics rpc in protocol? Return something like message MetricsResponse {repeated MetricFamily metrics = 1;} ?

Anyway, thank you for your reply. As http/2 is already supported, I'll close this issue.

@ZeeShen ZeeShen closed this Nov 7, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.