promql: int overflow not checked

[beorn7]

The float64 sample value can overflow an int, even and int64. We blindly convert to int (and not even int64) for the MOD operator in engine.go. This silently gives weird results instead of erroring or NaN'ing. It also breaks the test on certain architectures, cf. #2058.

The evalInt method has a similar issue.

evalInt should probably error out (as that's somewhere where an error is expected anyway). MOD should probably yield NaN (similar to MOD by 0).

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.