Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload of rules doesn't work, removed/updated rules should get removed/updated #2182

Closed
fvigotti opened this Issue Nov 11, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@fvigotti
Copy link

fvigotti commented Nov 11, 2016

  • prometheus v1.3.1
  • rules are loaded from dir using file globbing

when rules are updated, and reload is triggered ( both using http or signals ) new rules are reloaded correctly
BUT..

  • if rule file was previously loaded and the rule internal data has been changed: nothing change ( bug - rules never update if filename doesn't change )
  • if rule was previously loaded and another file with same rule name is inserted in the new configuration the rule get's overwritten ( which should be the correct behavior )
  • if the rule doesn't exist in the new configuration graph prometheus doesn't delete it ( bug - rules never gets deleted ) in this case, alertmanager restart seems to fix the issue ( but rules are loaded by prometheus so why this happens? this seems a design smell or a problem in the communication between the two anyway.. )
    this point seems to be a fault of alertmanager but I suppose that really the whole issue is inside prometheus which is the one who loads the new rules and should also have the responsability to update alertmanager.

now imagine a monitoring with some microservices / nodes that gets added/removed and maybe a CI system which update alerts from a SCM repository, It's very very frustrating having to reload the whole monitoring system ( prometheus) ( which also cause flush/reload databases ) for every rule added ( which could happen very frequently during some devops working session )

Because I think that alerting is one of the major features of a monitoring system this is a serious bug in my opinion (unfortunately I'm not fluent enough in go to PR myself :( )

Thank you,
Francesco

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Nov 14, 2016

Can you give a more concrete example? From what you are saying above, I cannot reproduce the problem.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Feb 13, 2017

Without further information, we cannot confirm this is an issue.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.