Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto set memory-chunk base on the available free memory detected #2188

Closed
netroby opened this Issue Nov 14, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@netroby
Copy link

netroby commented Nov 14, 2016

We know we can using golang runtime package to get memstats information. so we know the free memory available.

https://golang.org/pkg/runtime/

Now the default storage.local.memory-chunks be 1024*1024. It not good if the installed target machine have not enough memory. like a VM with only 512MB memory.

&cfg.storage.MemoryChunks, "storage.local.memory-chunks", 1024*1024,

So would we please add the auto detected memory?
We should not using more then 85% availble free memory. or we will got OOM .

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Nov 14, 2016

This is less trivial than suggested here.
In any case, what you want will be implemented as a solution of #455 .

@beorn7 beorn7 closed this Nov 14, 2016

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.