Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New armel test failure (panic: runtime error: index out of range) #2206

Closed
TheTincho opened this Issue Nov 18, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@TheTincho
Copy link
Contributor

TheTincho commented Nov 18, 2016

Me again :-)

Yesterday I uploaded a new release of 1.2.3 to Debian (I haven't uploaded 1.3 due to the kubernetes chain of dependencies), and I got this error during tests in armel.

It is worth noting that the previous release had the same source code, and was not failing, the only difference is that some dependencies got updated (oauth2 and logrus), but I don't see how those could be related..

=== RUN   TestDropMetrics
time="2016-11-18T02:42:54Z" level=info msg="Loading series map and head chunks..." source="storage.go:354" 
time="2016-11-18T02:42:54Z" level=info msg="0 series loaded." source="storage.go:359" 
time="2016-11-18T02:43:04Z" level=info msg="Maintenance loop stopped." source="storage.go:1224" 
panic: runtime error: index out of range

goroutine 655 [running]:
panic(0x423540, 0x10928028)
	/usr/lib/go-1.7/src/runtime/panic.go:500 +0x33c
github.com/prometheus/prometheus/storage/local.(*memorySeries).maybeCloseHeadChunk(0x11b7a050, 0x618714)
	/«BUILDDIR»/prometheus-1.2.3+ds2/build/src/github.com/prometheus/prometheus/storage/local/series.go:280 +0x290
github.com/prometheus/prometheus/storage/local.(*MemorySeriesStorage).maintainMemorySeries(0x10998600, 0x94b33977, 0x2ee1b8f2, 0x341bb166, 0xfffffe7a, 0xfffffd00)
	/«BUILDDIR»/prometheus-1.2.3+ds2/build/src/github.com/prometheus/prometheus/storage/local/storage.go:1327 +0x1d4
github.com/prometheus/prometheus/storage/local.(*MemorySeriesStorage).loop(0x10998600)
	/«BUILDDIR»/prometheus-1.2.3+ds2/build/src/github.com/prometheus/prometheus/storage/local/storage.go:1252 +0x400
created by github.com/prometheus/prometheus/storage/local.(*MemorySeriesStorage).Start
	/«BUILDDIR»/prometheus-1.2.3+ds2/build/src/github.com/prometheus/prometheus/storage/local/storage.go:370 +0x3e8
exit status 2
FAIL	github.com/prometheus/prometheus/storage/local	12.879s
@TheTincho

This comment has been minimized.

Copy link
Contributor Author

TheTincho commented Nov 24, 2016

It turns out it is some kind of flaky test. Most of the time, it runs fine, but sometimes there will be a panic. I haven't yet reproduced this in another architecture, but maybe it is just a timing issue.

Consistently, the "Maintenance loop stopped." message appears just before the panic, without a "Stopping maintenance loop...".

Any ideas?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 14, 2017

Is this still happening?

@TheTincho

This comment has been minimized.

Copy link
Contributor Author

TheTincho commented Jul 14, 2017

According to the latest armel logs, no.. Somewhere along the way it got fixed

@TheTincho TheTincho closed this Jul 14, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.