Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric for scrapes skipped due to throttling #2269

Closed
brian-brazil opened this Issue Dec 9, 2016 · 3 comments

Comments

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
2 participants
@brian-brazil @beorn7
@brian-brazil
Copy link
Member

brian-brazil commented Dec 9, 2016

We should have a metric to track this. We already have one for evals skipped.
@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member Author

brian-brazil commented Dec 9, 2016

We have this as prometheus_target_skipped_scrapes_total though if there's no skipped scrapes it won't show up. We should initialise this so this always shows.

@brian-brazil brian-brazil added the kind/enhancement label Dec 9, 2016

@beorn7

This comment has been minimized.

Sign in to view
Copy link
Member

beorn7 commented Dec 13, 2016

Definitely. Easy fix.

brian-brazil added a commit that referenced this issue Dec 16, 2016

@brian-brazil
Remove label from prometheus_target_skipped_scrapes_total 
This avoids it not being intialised, and breaking out by
interval wasn't partiuclarly useful.

Fixes #2269
Loading status checks…
3a8aa87

@brian-brazil brian-brazil referenced this issue Dec 16, 2016

Merged

Remove label from prometheus_target_skipped_scrapes_total #2289

@brian-brazil brian-brazil closed this in #2289 Dec 16, 2016

brian-brazil added a commit that referenced this issue Dec 16, 2016

@brian-brazil
Remove label from prometheus_target_skipped_scrapes_total (#2289) 
This avoids it not being intialised, and breaking out by
interval wasn't partiuclarly useful.

Fixes #2269
Loading status checks…
f421ce0
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.