Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promtool check-rules should alert on duplicates #2314

Closed
momorientes opened this Issue Jan 3, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@momorientes
Copy link

momorientes commented Jan 3, 2017

What did you do?
Duplicate Recording Rules(out of stupidity):

ifInRate{} = (rate(ifInOctets[1m])*8) / ifSpeed
ifInRate{} = (rate(ifOutOctets[1m])*8) / ifSpeed

What did you expect to see?
a warning of some kind when running promtool check-rules

What did you see instead? Under which circumstances?

WARN[8657] Error on ingesting results from rule evaluation with different value but same timestamp  numDropped=77 source=manager.go:299
@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jan 3, 2017

This is potentially a valid setup, there's no general way to detect this sort of thing.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented Jan 17, 2017

Indeed nothing that indicates an actual issue. We don't want to get into the business of warnings as that will be quite a rabbit hole.

@fabxc fabxc closed this Jan 17, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.