Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image should accept optional flags as ENV variables #2324

Closed
mstump opened this Issue Jan 6, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@mstump
Copy link

mstump commented Jan 6, 2017

With the current docker image there is no way to pass additional command line flags such as -web.external-url. Instead of invoking prometheus directly the image should invoke a shell script, optionally passing command line variables if they're specified in the environment.

@andrestc

This comment has been minimized.

Copy link
Contributor

andrestc commented Jan 7, 2017

Couldn't you just pass this cmd line flags directly to docker run? Those would override the CMD entry of the Dockerfile and will be fed directly to the ENTRYPOINT (prometheus binary).

@mstump

This comment has been minimized.

Copy link
Author

mstump commented Jan 11, 2017

you are correct.

@mstump mstump closed this Jan 11, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.