Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out if labeldrop/labelkeep are used with source_labels #2368

Closed
brian-brazil opened this Issue Jan 25, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@brian-brazil
Copy link
Member

brian-brazil commented Jan 25, 2017

This is non-nonsensical, so catch it when we parse the relabelling config.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jan 25, 2017

Same for target labels, regex, modulus, separator, right?

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Jan 26, 2017

We require the regex, nothing else should be non-default.

@roman-vynar

This comment has been minimized.

Copy link
Contributor

roman-vynar commented Jan 26, 2017

I agree as this is a bit confusing ref
Usually, you have label names under source_labels and compare their values in regex.
With labeldrop, you put label names into regex.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jan 26, 2017

Right, don't know how "regex" made it into my list :)

But yeah, the many conditionally used fields in relabeling are getting a bit confusing.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.