Expression browser metric autocomplete misses certain search terms

[juliusv]

Metric name fragments that are not a metric prefix (but contained somewhere in a metric name) and contain an underscore are not shown by the fuzzy-matching autocompleter in the expression browser.

For example, enter disk on http://demo.robustperception.io:9090/ to see that there are metrics node_disk_bytes_read, etc. Then enter disk_ to see that all those suggestions disappear.

This is likely related to 50f8e35. /cc @lightpriest

[lightpriest]

Yes, it's probably because of this change. The fuzzy matching breaks words by space. To perform the lookup, I remove the underscore from the metric name before looking up, and add it back after.

I wonder what will be the solution here. What would you expect the behavior to be? It might be treated as a space, or it might be treated as an underscore.

If treated as a space, then typing an underscore is meaningless, but the user was actually trying to do something - reduce the suggested options?
If treated as an underscore, maybe the code should fallback to the regular string matching? This will reduce the suggestion list, but in some cases might generate a different set of results.

[juliusv]

@lightpriest Hmm, not sure yet! Do you know why it does work if the search term is a metric prefix (like node_boot -> node_boot_time), but not if it's in the middle somewhere (boot_time)?

[lightpriest]

@juliusv #2396 includes a fix for this issue. It also includes a change to the library itself to provide better results.

I tried replacing the fuzzy search lib with atom's one (https://github.com/atom/fuzzaldrin), but it's targeted at path subjects, giving higher scores to the last path element, treats slash specially, etc.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.