Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uppanic: runtime error: invalid memory address or nil pointer dereference #2382
Comments
brian-brazil
added
component/service discovery
kind/bug
labels
Jan 31, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for reporting. Both instances seem rather odd as the API response seems to contain That can only really mean that AWS suddenly changed the contents of their API responses to have these fields zero'd out. Any chance you can run two small Prometheus servers with 1.3.1 and 1.5.0 in parallel and check whether one crashes while the other keeps going? |
This comment has been minimized.
This comment has been minimized.
|
yeah.. I have a staging env where I can run 1.3.1. I haven't spent much time with golang, unfortunately. Would it make more sense to have the API call dump its payload to file (this assuming all the data is pulled before parsing, and not parsed per tokenized page)? And naturally.. the problem hasn't reproduced since I posted this. ;) |
This comment has been minimized.
This comment has been minimized.
|
Might have been a one-time artifact. Probably should still be handled by the discovery. |
This comment has been minimized.
This comment has been minimized.
|
1.3.1 instance hasn't been crashing, but it's also not pulling the same set of data from AWS, unless Prom does a full decribe-instances pull, instead of individuals assets. |
This comment has been minimized.
This comment has been minimized.
|
Can you confirm this is no longer happening? |
This comment has been minimized.
This comment has been minimized.
|
I presume by the non-response that this is resolved. |
brian-brazil
closed this
Jul 14, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
nordbranch commentedJan 31, 2017
•
edited
What did you do?
Upgraded from prometheus-1.3.1.linux-amd64 to /opt/prometheus-1.5.0.linux-amd64/ .
Service will run for slightly less than 24hrs before encountering this issue. Little else was changed in going from 1.3.1 to 1.5.0. Problem was not experienced with 1.3.1.
What did you expect to see?
What did you see instead? Under which circumstances?
Environment
AWS EC2 c4.4xlarge
Linux 3.13.0-48-generic x86_64
./prometheus -version
prometheus, version 1.5.0 (branch: master, revision: d840f2c)
build user: root@a04ed5b536e3
build date: 20170123-13:56:24
go version: go1.7.4
(not likely relevant, but for completeness)
./alertmanager -version
alertmanager, version 0.4.2 (branch: master, revision: 9a5ab2fa63dd7951f4f202b0846d4f4d8e9615b0)
build user: root@2811d2f42616
build date: 20160902-15:33:13
go version: go1.6.3
We're aware of the sample discard messaging - we plan to use relabeling to deal with some of that. (Those were occurring under 1.3.1, as well, without this issue.) There are log captures from two events below.
Thanks!