Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View rendering only adds last sample from chunks to view #239

Closed
juliusv opened this Issue May 11, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@juliusv
Copy link
Member

juliusv commented May 11, 2013

I've cross-referenced the samples that get added to a view with a compacted DB-dump and noticed that only those samples which are the last samples of a chunk get added to a view. This would explain the query anomalies we've seen, and also, why the problem wasn't as visible without compaction (chunks of 1 or 2 samples).

We need to investigate why this happens.

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented May 11, 2013

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented May 11, 2013

Found the two bugs that cause this and verified that fixing them gives the correct behavior. Will send a PR once I have time to write tests.

@matttproud

This comment has been minimized.

Copy link
Member

matttproud commented May 11, 2013

Good detective work on this. You had me very troubled that we have a
problem with the underlying storage implementation.
Am 11.05.2013 16:35 schrieb "juliusv" notifications@github.com:

Found the two bugs that cause this and verified that fixing them gives the
correct behavior. Will send a PR once I have time to write tests.


Reply to this email directly or view it on GitHubhttps://github.com//issues/239#issuecomment-17760926
.

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented May 14, 2013

Fixed in #251

@juliusv juliusv closed this Jun 2, 2013

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.