Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upView rendering only adds last sample from chunks to view #239
Comments
This comment has been minimized.
This comment has been minimized.
|
/cc @matttproud |
This comment has been minimized.
This comment has been minimized.
|
Found the two bugs that cause this and verified that fixing them gives the correct behavior. Will send a PR once I have time to write tests. |
This comment has been minimized.
This comment has been minimized.
|
Good detective work on this. You had me very troubled that we have a
|
This comment has been minimized.
This comment has been minimized.
|
Fixed in #251 |
juliusv
closed this
Jun 2, 2013
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 25, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
juliusv commentedMay 11, 2013
I've cross-referenced the samples that get added to a view with a compacted DB-dump and noticed that only those samples which are the last samples of a chunk get added to a view. This would explain the query anomalies we've seen, and also, why the problem wasn't as visible without compaction (chunks of 1 or 2 samples).
We need to investigate why this happens.