Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Switch whitelist of Consul services to blacklist #2402

Closed
yannispanousis opened this Issue Feb 7, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@yannispanousis
Copy link

yannispanousis commented Feb 7, 2017

What did you expect to see?

I'm integrating Prometheus with Consul for service discovery and following this config

What did you see instead? Under which circumstances?

I expected to be able to rule out services I don't care to discover. Instead the configuration file only allows a whitelist. That effectively neutralises the usefulness of the service discovery, because now I have to keep the Prometheus scrape list up-to-date, whereas if it was a blacklist then I would only have to change that list for services I don't care about.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Feb 7, 2017

You can use a drop relabel action to do this.

@yannispanousis

This comment has been minimized.

Copy link
Author

yannispanousis commented Feb 7, 2017

Nice! That looks like some powerful stuff. (Just setting up the stack now so wasn't aware of this). Thanks man.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Feb 7, 2017

You're welcome.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.