Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification metrics #2429

Closed
brian-brazil opened this Issue Feb 15, 2017 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@brian-brazil
@brian-brazil
Copy link
Member

brian-brazil commented Feb 15, 2017

The per-AM notification metrics could do with some improvement.

They're success and failure rather than failure and total, and they aren't getting initialised to 0.

gouthamve added a commit to gouthamve/prometheus that referenced this issue Mar 2, 2017

@gouthamve
Better Metrics For Alerts 
* Closes prometheus#2429
* Moved metrics to top of file for easier access
* Initialised CounterVecs
Verified
This commit was signed with a verified signature.
@gouthamve gouthamve Goutham Veeramachaneni
GPG key ID: F1C217E8E9023CAD Learn about signing commits
41da5c4

@gouthamve gouthamve referenced this issue Mar 2, 2017

Merged

Better Metrics For Alerts #2465

@juliusv juliusv closed this in #2465 Mar 31, 2017

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.