Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom user agent #2440

Closed
grobie opened this Issue Feb 20, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@grobie
Copy link
Member

grobie commented Feb 20, 2017

Prometheus currently uses the default golang HTTP user agent Go-http-client/1.1. In order to unambiguously identify scrape requests, it'd be helpful to see a custom Prometheus user agent.

@matthiasr

This comment has been minimized.

Copy link
Contributor

matthiasr commented Feb 21, 2017

How does that relate to the Accept header that it sends?

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Feb 21, 2017

It wouldn't. This helps users debugging issues by making it easier to identify requests from Prometheus servers.

@matthiasr

This comment has been minimized.

Copy link
Contributor

matthiasr commented Feb 22, 2017

👍

@agaoglu

This comment has been minimized.

Copy link
Contributor

agaoglu commented Feb 24, 2017

PR sets a custom user agent, though i'm not sure about the name. Default was Go-http-client/1.1 proposed is Prometheus-scraper/1.0. Is that any good?

@grobie

This comment has been minimized.

Copy link
Member Author

grobie commented Feb 24, 2017

@agaoglu

This comment has been minimized.

Copy link
Contributor

agaoglu commented Feb 24, 2017

Updated PR to make use of build version.

@grobie grobie closed this Feb 28, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.