Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse custom user agent #2440
Comments
grobie
added
area/usability
kind/enhancement
labels
Feb 20, 2017
This comment has been minimized.
This comment has been minimized.
|
How does that relate to the Accept header that it sends? |
This comment has been minimized.
This comment has been minimized.
|
It wouldn't. This helps users debugging issues by making it easier to identify requests from Prometheus servers. |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
PR sets a custom user agent, though i'm not sure about the name. Default was |
This comment has been minimized.
This comment has been minimized.
|
I had something like "Prometheus v1.5.2" in mind. I'm open to more specific
agent identifiers like including "-scraper" of people think that removes
confusion.
…On Fri, Feb 24, 2017, 04:20 Erdem Agaoglu ***@***.***> wrote:
PR sets a custom user agent, though i'm not sure about the name. Default
was Go-http-client/1.1 proposed is Prometheus-scraper/1.0. Is that any
good?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2440 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANaH7TPPU54_pxYMLLJ_Ks9oxIX-3Gks5rfpLZgaJpZM4MGNTp>
.
|
This comment has been minimized.
This comment has been minimized.
|
Updated PR to make use of build version. |
grobie
closed this
Feb 28, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
grobie commentedFeb 20, 2017
Prometheus currently uses the default golang HTTP user agent
Go-http-client/1.1. In order to unambiguously identify scrape requests, it'd be helpful to see a custom Prometheus user agent.