Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust return signature of GetBoundaryValues() metric persistence method #25

Closed
juliusv opened this Issue Jan 8, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@juliusv
Copy link
Member

juliusv commented Jan 8, 2013

Current:

GetBoundaryValues(_model.LabelSet, *model.Interval, *StalenessPolicy) (_model.Sample, *model.Sample, error)

The return value is hard to use because the caller needs to manually match labelsets between the first and second return value e.g. for computing deltas. And there is nothing in the return types itself that ensures that the labels even do match.

So I think it should be the same as the GetRangeValues() return value:

GetBoundaryValues(_model.LabelSet, *model.Interval, *StalenessPolicy) (_model.SampleSet, error)

Downside: it's not explicit from the return type that it contains exactly two datapoints in each timeseries, but it's probably better than introducing yet another special type that ensures that.

@ghost ghost assigned matttproud Jan 8, 2013

@matttproud

This comment has been minimized.

Copy link
Member

matttproud commented Mar 27, 2013

@juliusv, this is likely obsolete.

@matttproud matttproud closed this Mar 27, 2013

matttproud added a commit that referenced this issue Apr 9, 2014

bobmshannon pushed a commit to bobmshannon/prometheus that referenced this issue Nov 19, 2018

Bob Shannon GitHub Enterprise
Add SLS health check endpoint (prometheus#25)
* Add health status endpoint

* Add healthutils package

* Add support for health check secret

* secret len
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.