Consider passing down scrape timeout as header

[brian-brazil]

I'd like to propose passing the scrape timeout down as a header when scraping. For exporters like snmp and blackbox it'd be good if the user didn't have to set timeouts in two places. More generally for expensive exporters, it'd be good to stop querying when the other side has given up. Whether this would ever be exposed to client libraries is a separate question.

This would be something like:

Scrape-Timeout-Seconds: 10.0 

[fabxc]

Why a header?
We should decide for either headers or query params. Given that we also discussed things like label selectors already, query params make the most sense.

[brian-brazil]

Headers could be automatic, whereas url parameters are currently explicitly configured by the user.

[fabxc]

Anything in the way of us adding default url params?

…

On Fri, Mar 17, 2017 at 3:54 PM Brian Brazil ***@***.***> wrote: Headers could be automatic, whereas url parameters are currently explicitly configured by the user. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2508 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEuA8v-pwezwsoold8wF7uaJPx0DmDovks5rmp6ygaJpZM4Mgqkv> .

[brian-brazil]

It doesn't seem quite as clean to me. It'd be exposing a minor internal detail on places like the /status page.

[grobie]

Closing the connection has signaled such timeout so far and most services at SoundCloud react to such event by aborting the processing of a request. Though, with the discussion around keep-alive this sounds like a useful hint. Intuitively a header also sounds like the better option to me to transport such meta information.

…

On Fri, Mar 17, 2017, 12:09 Brian Brazil ***@***.***> wrote: It doesn't seem quite as clean to me. It'd be exposing a minor internal detail on places like the /status page. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2508 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAANaHhUyf3Wr0-P9LMrfsVL3ayNxR43ks5rmqIXgaJpZM4Mgqkv> .

[juliusv]

Agreed on header in this case.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.