Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRename prometheus_build_info metric to build_info #2566
Comments
brian-brazil
added
the
priority/P3
label
Jul 14, 2017
brian-brazil
added this to the v2.x milestone
Jul 14, 2017
brian-brazil
added
kind/enhancement
low hanging fruit
help wanted
and removed
help wanted
labels
Jul 14, 2017
infoverload
referenced this issue
Jul 21, 2017
Closed
Remove program prefix from build_info metric #95
brian-brazil
changed the title
Rename build_info metric to prometheus_build_info
Rename prometheus_build_info metric to build_info
Jul 21, 2017
brian-brazil
added
priority/Pmaybe
and removed
priority/P3
labels
Jul 21, 2017
This comment has been minimized.
This comment has been minimized.
|
Fixed title to match description. I think the current way with the application name is probably the better way, as revisions are comparable between versions of a given binary but not across binaries. |
brian-brazil
removed
help wanted
low hanging fruit
labels
Jul 21, 2017
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil Yeah, kind of an edge case. You could still count the total number of Go versions you have in production across binaries though. But maybe that is not important enough. |
This comment has been minimized.
This comment has been minimized.
|
That'd be an argument for a separate metric for the go version I think. |
This comment has been minimized.
This comment has been minimized.
|
Thinking a little more, we probably the Go version to be a default metric that comes with client_golang. |
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil That totally makes sense. |
This comment has been minimized.
This comment has been minimized.
|
Closing in favor of prometheus/client_golang#328 |
juliusv
closed this
Jul 23, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 23, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
mattbostock commentedApr 4, 2017
The
prometheus_build_infometric is a useful way to confirm the running version of Prometheus, as isalertmanager_build_infofor Alertmanager.Since both metrics have a
joblabel that allows them to be distinguished, I propose that we rename them tobuild_info.