Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename prometheus_build_info metric to build_info #2566

Closed
mattbostock opened this Issue Apr 4, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@mattbostock
Copy link
Contributor

mattbostock commented Apr 4, 2017

The prometheus_build_info metric is a useful way to confirm the running version of Prometheus, as is alertmanager_build_info for Alertmanager.

Since both metrics have a job label that allows them to be distinguished, I propose that we rename them to build_info.

@brian-brazil brian-brazil added this to the v2.x milestone Jul 14, 2017

@brian-brazil brian-brazil changed the title Rename build_info metric to prometheus_build_info Rename prometheus_build_info metric to build_info Jul 21, 2017

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 21, 2017

Fixed title to match description.

I think the current way with the application name is probably the better way, as revisions are comparable between versions of a given binary but not across binaries.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jul 21, 2017

@brian-brazil Yeah, kind of an edge case. You could still count the total number of Go versions you have in production across binaries though. But maybe that is not important enough.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 21, 2017

That'd be an argument for a separate metric for the go version I think.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jul 21, 2017

Thinking a little more, we probably the Go version to be a default metric that comes with client_golang.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jul 21, 2017

@brian-brazil That totally makes sense.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Jul 23, 2017

Closing in favor of prometheus/client_golang#328

@juliusv juliusv closed this Jul 23, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.